fix(backend): Fix unhandled handshake error - #2541
Merged
Merged
Conversation
brkalow
requested review from
a team and
LekoArts
and removed request for
a team
January 10, 2024 18:31
🦋 Changeset detectedLatest commit: f8a1026 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Comment on lines
+210
to
+211
| // If for some reason the handshake token is invalid or stale, we ignore it and continue trying to authenticate the request. | ||
| // Worst case, the handshake will trigger again and return a refreshed token. |
Contributor
There was a problem hiding this comment.
Is it possible that this would lead to an infinite redirect loop, if FAPI will not return a fresh token ?
Member
Author
There was a problem hiding this comment.
Yes, it seems less likely that FAPI would return a stale token / invalid handshake payload though. For some reason we're seeing stale handshake cookies here, so the only solution is to move past the handshake handling and attempt to authenticate the request like normal.
panteliselef
approved these changes
Jan 10, 2024
nikosdouvlis
approved these changes
Jan 10, 2024
brkalow
enabled auto-merge
January 10, 2024 19:00
brkalow
added this pull request to the merge queue
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the handshake flow that would cause an unhandled error if the handshake payload or session token in the handshake payload fails to be verified.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore